Slightly simplify the way to create the editor toolbar #19993
Conversation
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0be3afff7e3f92f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/93ff72870d53578/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0be3afff7e3f92f/output.txt Total script time: 13.23 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/93ff72870d53578/output.txt Total script time: 31.41 mins
|
calixteman
force-pushed
the
editor_toolbar_simplification
branch
2 times, most recently
from
cc53b8a to
84c185c
Compare
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/fb598445de75bf0/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/36826b5d80f1942/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/36826b5d80f1942/output.txt Total script time: 13.26 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/fb598445de75bf0/output.txt Total script time: 29.65 mins
|
calixteman
requested review from
timvandermeij
and removed request for
Snuffleupagus
| } | ||
|
|
||
| addSignature(data, heightInPage, description, uuid) { | ||
| const { x: savedX, y: savedY } = this; | ||
| const { outline } = (this.#signatureData = data); | ||
| this.#isExtracted = outline instanceof ContourDrawOutline; | ||
| this.#description = description; | ||
| this.description = description; |
There was a problem hiding this comment.
Is this correct because the class already has a public description getter at
pdf.js/src/display/editor/signature.js
Line 214 in 84c185c
There was a problem hiding this comment.
There's a setter just after so it should be fine, right ?
calixteman
force-pushed
the
editor_toolbar_simplification
branch
from
84c185c to
2548405
Compare
No description provided.