Move getContext call to InternalRenderTask #20016
Open
+48
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzokuken
force-pushed
the
move-getcontext
branch
3 times, most recently
from
2027870 to
f89b738
Compare
This is a precursor to moving the call into a worker thread to let us use `OffscreenCanvas`. The current position wouldn't work since we make transformations to the canvas object after the getContext call, which isn't allowed for OffscreenCanvas. Also it isn't allowed to clone or `transferControlToOffscreen` the canvas after the `getContext` call.
ryzokuken
force-pushed
the
move-getcontext
branch
from
f89b738 to
680988d
Compare
GV222
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
getContextcall out of_createContextand intoInternalRenderTask#initializeGraphicsand adapt tests accordingly.This is a precursor to moving the call into a worker thread to let us use
OffscreenCanvas. The current position wouldn't work since we make transformations to the canvas object after thegetContextcall, which isn't allowed forOffscreenCanvas. Also it isn't allowed to clone ortransferControlToOffscreenthe canvas after thegetContextcall.