-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[Editor] Fix the accessibility of the dropdown in the color picker #20022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/660f2c6c6ef5a97/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/fe849730c650599/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/660f2c6c6ef5a97/output.txt Total script time: 17.24 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/fe849730c650599/output.txt Total script time: 32.47 mins
|
24d71fb to
c326eca
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/435907c4a9019bd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8042262915dcfe5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/435907c4a9019bd/output.txt Total script time: 15.68 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8042262915dcfe5/output.txt Total script time: 31.10 mins
|
c326eca to
1f2e9e5
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/ca7f160d519470a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/f2a55cd181aa3d2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ca7f160d519470a/output.txt Total script time: 14.54 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/f2a55cd181aa3d2/output.txt Total script time: 28.97 mins
|
| .map(pair => pair.split("=").map(x => x.trim())) | ||
| this.#highlightColors.split(",").map(pair => { | ||
| pair = pair.split("=").map(x => x.trim()); | ||
| pair[1] = pair[1].toUpperCase(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of upper-casing the color strings in this patch exactly? I'm not really clear on why that is necessary to improve accessibility.
No description provided.