Merge pull request #20011 from calixteman/bug1971134

calixteman · web-flow · commit 35b604b9f895 · 2025-06-17T21:18:50.000+02:00
[Editor] Fix the text alignment in freetext annotations (bug 1971134)
diff --git a/test/integration/freetext_editor_spec.mjs b/test/integration/freetext_editor_spec.mjs
@@ -3309,4 +3309,52 @@ describe("FreeText Editor", () => {
       );
     });
   });
+
+  describe("Freetext and text alignment", () => {
+    let pages;
+
+    beforeEach(async () => {
+      pages = await loadAndWait("empty.pdf", ".annotationEditorLayer");
+    });
+
+    afterEach(async () => {
+      await closePages(pages);
+    });
+
+    it("must check that the alignment is correct", async () => {
+      await Promise.all(
+        pages.map(async ([browserName, page]) => {
+          await switchToFreeText(page);
+
+          const rect = await getRect(page, ".annotationEditorLayer");
+          const editorSelector = getEditorSelector(0);
+
+          const data = "Hello PDF.js World !!";
+          await page.mouse.click(rect.x + 100, rect.y + 100);
+          await page.waitForSelector(editorSelector, { visible: true });
+          await page.type(`${editorSelector} .internal`, data);
+          await commit(page);
+          await waitForSerialized(page, 1);
+
+          let alignment = await page.$eval(
+            `${editorSelector} .internal`,
+            el => getComputedStyle(el).textAlign
+          );
+          expect(alignment).withContext(`In ${browserName}`).toEqual("start");
+
+          await page.click("#secondaryToolbarToggleButton");
+          await page.waitForSelector("#secondaryToolbar", { visible: true });
+          await page.click("#spreadOdd");
+          await page.waitForSelector("#secondaryToolbar", { visible: false });
+          await page.waitForSelector(".spread");
+
+          alignment = await page.$eval(
+            `${editorSelector} .internal`,
+            el => getComputedStyle(el).textAlign
+          );
+          expect(alignment).withContext(`In ${browserName}`).toEqual("start");
+        })
+      );
+    });
+  });
 });
diff --git a/web/annotation_editor_layer_builder.css b/web/annotation_editor_layer_builder.css
@@ -517,6 +517,7 @@
   white-space: nowrap;
   font: 10px sans-serif;
   line-height: var(--freetext-line-height);
+  text-align: start;
   user-select: none;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -517,6 +517,7 @@`
`517`	`517`	`white-space: nowrap;`
`518`	`518`	`font: 10px sans-serif;`
`519`	`519`	`line-height: var(--freetext-line-height);`
	`520`	`+ text-align: start;`
`520`	`521`	`user-select: none;`
`521`	`522`	`}`
`522`	`523`